Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Doesn't work in Crystal 1.4.0 #464

Conversation

VanyaNeytrino
Copy link

trying to solve the issue #463 if you know a better way, I will be glad to hear and make corrections.

@Blacksmoke16
Copy link
Contributor

I'm pretty sure all you need to do is upgrade to Crystal 1.4.1. This was a regression that was fixed in crystal-lang/crystal#11995.

@VanyaNeytrino
Copy link
Author

VanyaNeytrino commented May 15, 2022

I'm pretty sure all you need to do is upgrade to Crystal 1.4.1. This was a regression that was fixed in crystal-lang/crystal#11995.
unfortunately this is not the case

Screenshot 2022-05-15 at 12 12 52

@Blacksmoke16
Copy link
Contributor

Oh wow okay, I guess it's been broken since 1.0.0 then 😬. In that case, I think a better fix would be replacing https://github.com/amberframework/granite/blob/master/src/granite/transactions.cr#L264 with a call to set_timestamps, much like it does in https://github.com/amberframework/granite/blob/master/src/granite/transactions.cr#L141 and that should fix it, and be backwards compatible.

@confact
Copy link

confact commented May 19, 2022

Tested master with 1.4.1 and #465 seemed to have fixed this issue.

@robacarp
Copy link
Member

@VanyaNeytrino I think this is fixed elsewhere so I'm going to close. Feel free to re-open if there's other stuff in here that's relevant.

@robacarp robacarp closed this May 19, 2022
@VanyaNeytrino VanyaNeytrino deleted the fix_doesnt_work_in_crystal_1.4.0 branch May 22, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants