Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Would like to have the Connection Icon back on the UI.PWA Navigation Bar #752

Closed
jjsenay opened this issue Oct 8, 2021 · 6 comments · Fixed by #754
Closed

[FEATURE] Would like to have the Connection Icon back on the UI.PWA Navigation Bar #752

jjsenay opened this issue Oct 8, 2021 · 6 comments · Fixed by #754
Assignees
@vickywane
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed released

Comments

@jjsenay
Copy link

jjsenay commented Oct 8, 2021

All,

Having the Cloud Connect Icon should be in the UI.PWA navigation bar. This will aid in trouble shooting of an EDGE installation. A tech support person can asked about the Cloud Connect Icon to help diagnose a problem.

Thanks!!
@jjsenay jjsenay added the enhancement New feature or request label Oct 8, 2021
@ivelin
Copy link
Contributor

ivelin commented Oct 8, 2021

Lets clarify. The cloud connectivity icon currently shows when the UI is in Disconnected state (cloud-off icon) or in Connecting state (cloud-sync icon). It disappears when the connection to a remote edge is established.

You are asking to have an icon that indicates there is currently an active connection to an edge device correct? Maybea cloud-done icon for Connected state.

Screen Shot 2021-10-08 at 12 14 56 PM

@ivelin ivelin changed the title Would like to have the Connection Icon back on the UI.PWA Navigation Bar [FEATURE] Would like to have the Connection Icon back on the UI.PWA Navigation Bar Oct 8, 2021
@jjsenay
Copy link
Author

jjsenay commented Oct 8, 2021 via email

@ivelin
Copy link
Contributor

ivelin commented Oct 8, 2021

Understood. @vickywane interested?

@ivelin ivelin added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 8, 2021
@vickywane
Copy link
Contributor

Yes, I will like to take this issue up.

@vickywane vickywane mentioned this issue Oct 10, 2021
Merged
5 tasks
@vickywane
Copy link
Contributor

This pull request has been created to close this issue.

@ivelin ivelin linked a pull request Oct 10, 2021 that will close this issue
feat: modified cloud connection icon to show for PEER_CONNECTED state #754
Merged
5 tasks
ivelin pushed a commit that referenced this issue Oct 11, 2021
@vickywane
feat: show cloud connection icon in navbar when UI is connected to an…
6ee362f 
… edge device; closes #752
github-actions bot pushed a commit that referenced this issue Oct 11, 2021
@semantic-release-bot
chore(release): 2.20.0
465bc61 
# [2.20.0](v2.19.5...v2.20.0) (2021-10-11)

### Features

* show cloud connection icon in navbar when UI is connected to an edge device; closes [#752](#752) ([6ee362f](6ee362f))
@ivelin
Copy link
Contributor

ivelin commented Oct 11, 2021

🎉 This issue has been resolved in version 2.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vickywane vickywane

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: modified cloud connection icon to show for PEER_CONNECTED state vickywane/ambianic-ui
3 participants
@ivelin @jjsenay @vickywane