LPS-68180 Update build script rules

[csierra]

/cc @topolik Test is not passing because antisamy formats the output in a different way than the test expects

[csierra]

hey @Ithildir, could you please have a look at this pull? I did what you suggested of keeping the file in git and execute the download task only when the file is missing. I have a problem, though, and it is that source formatter tries to format source the file and it fails miserably.

Is there any way to prevent source formatter from "fixing" this configuration XML?

Thanks.

[csierra]

ci:stop

[liferay-continuous-integration]

Some tests FAILED.

Build Time: 4 minutes 13 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 9434a0fada56145d578618d5483b4851c5ad726b

Job Summary:

• test-portal-acceptance-pullrequest(master)
• test-portal-acceptance-pullrequest-dist(master)/jdk8
• test-portal-acceptance-pullrequest-source(master)

For more details click here.

---

Failed Jobs:

1. test-portal-acceptance-pullrequest(master)

   Job Results:

   1 Job Passed.
   2 Jobs Failed.

   Completed with the status of ABORTED.

2. test-portal-acceptance-pullrequest-dist(master)/jdk8

   Build was aborted

For upstream results, click here.

[Ithildir]

Hi @csierra!

Have you tried to add a source.formatter.excludes line in this source-formatter.properties?

[csierra]

hey @Ithildir... no... but that's global, isn't it? don't we have anything local to the module?

[Ithildir]

I've seen that @hhuijser changed things lately, it seems that modules (or groups of modules like portal-security) can have their own source-formatter.properties. For example here.

[csierra]

hey... that's cool but are the paths still relative to the root of the portal instead of the module?

[csierra]

I tried both in portal-security and portal-security-antisamy with no luck. gradlew formatSource is still failing :-(

[Ithildir]

Then we need to summon @hhuijser to shine a light on this...

[csierra]

summon summon \o/

[hhuijser]

@csierra it worked for me: csierra#250

If you keep having problems, I'd suggest rebasing to latest master and making sure you're running latest SF.

[ambrinchaudhary]

Just started reviewing :)

Sent from GH.

[topolik]

@csierra Just out of curiosity, this is a mime type regex, correct? Mime types contain also dashes. Or is it any intent in leaving the dash outside? Thx!

[ambrinchaudhary]

This was the new PR: #102