Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #43: React.createClass is deprecated (create-react-class) #45

Merged
merged 2 commits into from
Apr 24, 2017
Merged

fixes #43: React.createClass is deprecated (create-react-class) #45

merged 2 commits into from
Apr 24, 2017

Conversation

Izumi-kun
Copy link

Second way for fix #43 (using create-react-class). I think this is more safe.

Pauan
Pauan requested changes Apr 22, 2017
View reviewed changes
Copy link
Collaborator

@Pauan Pauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

However, it's missing changes to examples/script/example.js, and it's missing changes to the package.json in all of the examples

@Izumi-kun
Copy link
Author

Izumi-kun commented Apr 22, 2017 •
edited
Loading

This PR for 2.x.x branch where is no examples/script/example.js.

@Pauan Pauan merged commit 924a6d7 into amcharts:2.x.x Apr 24, 2017
@Pauan
Copy link
Collaborator

Pauan commented Apr 24, 2017

@Izumi-kun You're right, thanks!

@Izumi-kun Izumi-kun deleted the fix-43-2 branch April 25, 2017 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pauan Pauan Pauan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Izumi-kun @Pauan