Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Commit

Permalink
fix: manifest and favicons were returning 404s
Browse files Browse the repository at this point in the history
favicon.ico and site.webmanifest should be in root of domain.
Everything else goes into /static so it's easy to set TTL and
other headers by path filter

Fixes #424
  • Loading branch information
amclin committed Jun 26, 2020
1 parent 21ebbcb commit 92358de
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
"short_name": "%%APPNAME%%",
"icons": [
{
"src": "/android-chrome-192x192.png",
"src": "/static/android-chrome-192x192.png",
"sizes": "192x192",
"type": "image/png"
},
{
"src": "/android-chrome-512x512.png",
"src": "/static/android-chrome-512x512.png",
"sizes": "512x512",
"type": "image/png"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,19 @@ const Favicon = () => {
rel="apple-touch-icon"
type="image/png"
sizes="180x180"
href="/apple-touch-icon.png"
href="/static/apple-touch-icon.png"
/>
<HeadLink
rel="icon"
type="image/png"
sizes="32x32"
href="/favicon-32x32.png"
href="/static/favicon-32x32.png"
/>
<HeadLink
rel="icon"
type="image/png"
sizes="16x16"
href="/favicon-16x16.png"
href="/static/favicon-16x16.png"
/>
</>
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,19 @@
exports[`Favicon creates a list of <link> elements for favicon suitable for the document head 1`] = `
<DocumentFragment>
<link
href="/apple-touch-icon.png"
href="/static/apple-touch-icon.png"
rel="apple-touch-icon"
sizes="180x180"
type="image/png"
/>
<link
href="/favicon-32x32.png"
href="/static/favicon-32x32.png"
rel="icon"
sizes="32x32"
type="image/png"
/>
<link
href="/favicon-16x16.png"
href="/static/favicon-16x16.png"
rel="icon"
sizes="16x16"
type="image/png"
Expand Down

0 comments on commit 92358de

Please sign in to comment.