-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow https #156
Allow https #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http.request(req) | ||
end | ||
end | ||
|
||
def secure? | ||
env['protocol'] == SECURE_PROTOCOL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if we should drop the protocol part of this since it doesn't look like we use that in the underlying connection and instead just use a use_ssl: true
type flag in the config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protocol
is used on https://github.com/amco/dolly/blob/3.0/lib/dolly/configuration.rb#L13 to set the base_uri
for the connection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but it could be hard coded as constants and the correct one used based on the use_ssl flag. It is fine either way, just seems we could create one less typo issue and not have to worry about a string comparison. Was just a thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will raise an issue to do so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just need to check as this will make current config invalid, as not many projects have Dolly3, should be fine, but there are some on development already using it.
Set
use_ssl
based onprotocol
option under couchdb.yml