Allow https #156
Allow https #156
Conversation
| http.request(req) | ||
| end | ||
| end | ||
|
|
||
| def secure? | ||
| env['protocol'] == SECURE_PROTOCOL |
There was a problem hiding this comment.
Just wondering if we should drop the protocol part of this since it doesn't look like we use that in the underlying connection and instead just use a use_ssl: true type flag in the config.
There was a problem hiding this comment.
protocol is used on https://github.com/amco/dolly/blob/3.0/lib/dolly/configuration.rb#L13 to set the base_uri for the connection.
There was a problem hiding this comment.
Right, but it could be hard coded as constants and the correct one used based on the use_ssl flag. It is fine either way, just seems we could create one less typo issue and not have to worry about a string comparison. Was just a thought.
There was a problem hiding this comment.
ok, will raise an issue to do so
There was a problem hiding this comment.
I just need to check as this will make current config invalid, as not many projects have Dolly3, should be fine, but there are some on development already using it.
Set
use_sslbased onprotocoloption under couchdb.yml