fix imported targets with multiple configuration #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Csaba Sipos <siposcsaba89@gmail.com>
dirk-thomas
reviewed
Oct 19, 2020
ament_cmake_export_dependencies/cmake/ament_cmake_export_dependencies-extras.cmake.in
Outdated
Show resolved
Hide resolved
Signed-off-by: Csaba Sipos <siposcsaba89@gmail.com>
|
|
Thank you for the patch. |
|
TRANSFORM?
|
Yes, and sorry for the inconvenience, I should have checked it before creating the pull request. Plesase see: #296 |
hidmic
pushed a commit
that referenced
this pull request
Apr 12, 2021
…cmake (#290) (#296) (#331) * fix imported targets with multiple configuration (#290) * fix imported targets with multiple configuration Signed-off-by: Csaba Sipos <siposcsaba89@gmail.com> * taking into account DEBUG_CONFIGURATIONS global variable Signed-off-by: Csaba Sipos <siposcsaba89@gmail.com> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix cmake list(TRANSFORM ) is only available from version 3.12, (#296) convert to string instead Signed-off-by: Csaba Sipos <siposcsaba89@gmail.com> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: siposcsaba89 <siposcsaba89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I would like to propose a change to handle dependency packages with multiple configurations using debug | optimized keywords as stated in the cmake documentation:
https://cmake.org/cmake/help/v3.0/command/target_link_libraries.html
Best Regards,
Csaba