Fix test skipping logic for missing pytest module #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott K Logan <logans@cottsay.net>
clalancette
approved these changes
Apr 12, 2023
ejalaa12
pushed a commit
to ejalaa12/ament_cmake
that referenced
this pull request
Nov 8, 2023
Signed-off-by: Scott K Logan <logans@cottsay.net>
clalancette
pushed a commit
that referenced
this pull request
Nov 10, 2023
* backport merge #381 to humble * ament_cmake_pytest needs a buildtool_depend on ament_cmake_test. (#439) * Add missing buildtool_depend on python3-pytest (#440) * Fix test skipping logic for missing pytest module (#441) Signed-off-by: Alaa El Jawad <ejalaa12@gmail.com> Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Scott K Logan <logans@cottsay.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing behavior is to
return()from the top-level CMake script if pytest is absent, which means that the package isn't ever built or installed.Follow-up to #440 and #381.