Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport merge #381 to humble #490

Merged
merged 4 commits into from Nov 10, 2023
Merged

backport merge #381 to humble #490

merged 4 commits into from Nov 10, 2023

Conversation

ejalaa12
Copy link
Contributor

@ejalaa12 ejalaa12 commented Nov 6, 2023

This PR is a backport of #381 to humble.
There is no incompatibility, and it's relevant for people still using humble.

@ejalaa12
backport merge ament#381 to humble
6e8bf07 
Signed-off-by: Alaa El Jawad <ejalaa12@gmail.com>
clalancette
clalancette requested changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this backport will also need #439 , #440 , and #441 to actually work properly on Humble.

clalancette and others added 3 commits November 8, 2023 14:35
@clalancette @ejalaa12
ament_cmake_pytest needs a buildtool_depend on ament_cmake_test. (ame…
71e52d9 
…nt#439)

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@cottsay @ejalaa12
Add missing buildtool_depend on python3-pytest (ament#440)
dc9140a 
Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay @ejalaa12
Fix test skipping logic for missing pytest module (ament#441)
a345a1f 
Signed-off-by: Scott K Logan <logans@cottsay.net>
@ejalaa12
Copy link
Contributor Author

ejalaa12 commented Nov 8, 2023 •
edited

Hi, I just cherry picked the related commits.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit ca544b2 into ament:humble Nov 10, 2023
3 checks passed
@ejalaa12 ejalaa12 deleted the humble branch November 13, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ejalaa12 @clalancette @cottsay