Add EXTEND_EXISTING argument to ament_python_install_package #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roland Arsenault <roland@ccom.unh.edu>
rolker
force-pushed
the
add_extend_existing_python
branch
from
02e8229
to
7992790
Compare
This was referenced Mar 7, 2024
|
While this pokes at the right direction, I don't think this is the way we should go. See my comment in ros2/rosidl_python#141 (comment) . I'm going to close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to implement #514 to solve ros2/rosidl_python#141.
Python eggs and CMake macros are not my strong points so I would appreciate any advice on improving this solution.