Fix headers destination installed by ament_auto_package #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
|
This PR needs to be backported to Humble, Iron and Jazzy. |
|
I make this to draft because I found some fixes are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix ros2/ros2#1150, many packages that are resigtered in rosdistro, are fixed like ament/ament_index#83.
This repository was not fixed at the time because it was not directly involved in installing header files.
However, all packages provided by this repository that use ament_auto_package to install header files have the issue reported in ros2/ros2#1150, which this PR will fix.