Update Quality Declaration of ament_index_cpp to reflect QL 2 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
force-pushed
the
brawner/quality-declaration-ql-2
branch
from
6566f33
to
e6d7e73
Compare
ahcorde
reviewed
Jun 5, 2020
|
|
||
| ### Public API Documentation [3.ii] | ||
|
|
||
| Some `ament_index_cpp` API functions are documented using docstrings. However, this is not hosted anywhere. | ||
| Some `ament_index_cpp` API functions are documented using docstrings, and it is [hosted](http://docs.ros2.org/latest/api/ament_index_cpp/index.html). |
There was a problem hiding this comment.
Documentation is not still alive
ahcorde
approved these changes
Jun 5, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Blast545
reviewed
Jun 5, 2020
| @@ -114,7 +115,7 @@ This includes: | |||
|
|
|||
| Changes are required to make a best effort to keep or increase coverage before being accepted, but decreases are allowed if properly justified and accepted by reviewers. | |||
|
|
|||
| Current coverage statistics can be viewed [here](https://ci.ros2.org/job/ci_linux_coverage/85/cobertura/src_ament_ament_index_ament_index_cpp_src/). | |||
| Current coverage statistics can be viewed [here](https://ci.ros2.org/job/ci_linux_coverage/lastBuild/cobertura/src_ament_ament_index_ament_index_cpp_src/). | |||
There was a problem hiding this comment.
Suggested change
| Current coverage statistics can be viewed [here](https://ci.ros2.org/job/ci_linux_coverage/lastBuild/cobertura/src_ament_ament_index_ament_index_cpp_src/). | |
| Current coverage statistics can be viewed [here](https://ci.ros2.org/job/ci_linux_coverage/lastSuccessfulBuild/cobertura/src_ament_ament_index_ament_index_cpp_src/). |
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Blast545
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Quality Declaration to reflect the QL 2 status of this ament_index_cpp.
Signed-off-by: Stephen Brawner brawner@gmail.com