Update QD to Quality Level 1 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Brawner <brawner@gmail.com>
wjwwood
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
lgtm
During my review I read the whole document, and though out of the scope of this pr, I found to issues. First the link in this line is 404 for me:
All the functionality of the declared API in this package is covered in its unit tests. Currently it has a line coverage of 99%.
Also, this line doesn't make sense to me:
- achieving and maintaining a reasonable branch line coverage (90-100%)
It should be branch or line coverage or just branch coverage or just line coverage, maybe?
|
I agree that this PR would be suitable for fixing up any remaining issues. It will get less frequent updates now that it's been bumped to QL 1. I updated the coverage link and updated that line to read |
Blast545
approved these changes
Aug 25, 2020
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen Brawner brawner@gmail.com