Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install includes to include/${PROJECT_NAME} #83

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jan 5, 2022

Part of ros2/ros2#1150

This installs includes to include/${PROJECT_NAME} to mitigate include directory search order issues when overriding packages in desktop.

Marked as draft because I'm opening a bunch of PRs at once to run CI all at the same time.

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz self-assigned this Jan 5, 2022
Copy link
Contributor

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI. Feel free to add me as a reviewer on the related PRs as they come out of draft state.

@sloretz
Copy link
Contributor Author

sloretz commented Jan 10, 2022

Looks good to me with green CI. Feel free to add me as a reviewer on the related PRs as they come out of draft state.

It looks like some of the packages will take longer, so I'll do CI with a repos file

CI (repos file build: --packages-above-and-dependencies ament_index_cpp test: --packages-select ament_index_cpp)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants