change test runner to work on windows #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
force-pushed
the
test_runner_windows
branch
from
c275287
to
d65c274
Compare
dirk-thomas
added
in review
|
Lgtm, but why was so much code removed in |
dirk-thomas
force-pushed
the
test_runner_windows
branch
from
cc8cf4b
to
f042c2e
Compare
|
Ups, the copyright stuff was not intended to be in that commit. I updated the PR to exclude the copyright stuff. |
|
+1 |
| foreach(arg ${ARG_UNPARSED_ARGUMENTS}) | ||
| set(subcmd "${subcmd} \"${arg}\"") | ||
| endforeach() | ||
| set(cmd "${ament_copyright_BIN}" "--xunit-file" "${AMENT_TEST_RESULTS_DIR}/${PROJECT_NAME}/${ARG_TESTNAME}.xml") |
There was a problem hiding this comment.
No PYTHON_EXECUTABLE on this line? All the others have it.
There was a problem hiding this comment.
No, it is an extension point which will generate an executable on Windows. And the command didn't use PYTHON_EXECUTABLE before this PR.
|
+1 |
1 similar comment
|
+1 |
dirk-thomas
added a commit
that referenced
this pull request
Mar 31, 2015
change test runner to work on windows
kenji-miyake
referenced
this pull request
in kenji-miyake/ament_lint
Oct 20, 2021
change test runner to work on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ament/ament_cmake#7.
Connects to ament/ament_cmake#7