Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3-yaml depends to ament_clang_tidy/format #166

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

JShep1
Copy link
Contributor

@JShep1 JShep1 commented Jul 30, 2019

This is added due to a CI build failure (#165) that occurs due to pyyaml being added to setup.py installation reqs (#150) but python3-yaml not existing in package.xml as a dependency.

Signed-off-by: John Shepherd john@openrobotics.org

@rotu rotu mentioned this pull request Jul 30, 2019
@dirk-thomas
Copy link
Contributor

Wouldn't an exec_depend be sufficient in both cases?

Signed-off-by: John Shepherd <john@openrobotics.org>

depend -> exec_depend

Signed-off-by: John Shepherd <john@openrobotics.org>

Remove whitespace

Signed-off-by: John Shepherd <john@openrobotics.org>

Remove ws

Signed-off-by: John Shepherd <john@openrobotics.org>
@JShep1 JShep1 force-pushed the jshep1/addpyyaml_depend_to_linters branch from d4f4a3a to 52e1e36 Compare July 30, 2019 22:37
@JShep1 JShep1 merged commit 0ff554e into master Jul 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the jshep1/addpyyaml_depend_to_linters branch July 30, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants