Convert list comprehension to generator #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses flake8 C412 errors introduced by flake8-comprehension 2.2.0 Signed-off-by: Scott K Logan <logans@cottsay.net>
dirk-thomas
approved these changes
Aug 12, 2019
dirk-thomas
pushed a commit
that referenced
this pull request
Oct 10, 2019
Addresses flake8 C412 errors introduced by flake8-comprehension 2.2.0 Signed-off-by: Scott K Logan <logans@cottsay.net> (cherry picked from commit 3714573)
dirk-thomas
added a commit
that referenced
this pull request
Oct 10, 2019
kenji-miyake
pushed a commit
to kenji-miyake/ament_lint
that referenced
this pull request
Oct 20, 2021
Addresses flake8 C412 errors introduced by flake8-comprehension 2.2.0 Signed-off-by: Scott K Logan <logans@cottsay.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses flake8 C412 errors introduced by flake8-comprehension 2.2.0
https://github.com/adamchainz/flake8-comprehensions/blob/master/README.rst#c412-unnecessary-list-comprehension---in-can-take-a-generator
See ros2/build_farmer#228