Allow AMENT_IGNORE markers to be directories #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Rose <dan@digilabs.io>
|
Pending the question discussed on ros-infrastructure/catkin_pkg#286 (comment) |
|
With the REP update merged (ros-infrastructure/rep#256) I will go ahead ad merge this. |
kenji-miyake
pushed a commit
to kenji-miyake/ament_lint
that referenced
this pull request
Oct 20, 2021
Signed-off-by: Dan Rose <dan@digilabs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches
COLCON_IGNORE, which checks that a file exists, not necessarily that it is a normal file.Signed-off-by: Dan Rose dan@digilabs.io