clarify CATKIN_IGNORE may be a file, directory, or (dangling) symlink #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mention that CATKIN_IGNORE may be any type of file
change "are ignored" to "don't matter" to avoid implying that that's what "IGNORE" is referring to in "CATKIN_IGNORE"
dirk-thomas
reviewed
Apr 29, 2020
rotu
added a commit
to rotu/colcon-core
that referenced
this pull request
Apr 29, 2020
dirk-thomas
approved these changes
Apr 29, 2020
|
@ros-infrastructure/ros_team Please review and approve this proposed change. |
mjcarroll
approved these changes
Apr 29, 2020
rotu
added a commit
to rotu/colcon-core
that referenced
this pull request
Apr 29, 2020
Answered my own question: ros-infrastructure/catkin_pkg#286 (comment) |
rotu
added a commit
to rotu/colcon-bundle
that referenced
this pull request
Apr 29, 2020
dirk-thomas
changed the title
dirk-thomas
changed the title
|
3 👍 and 5 days sounds like enough to me. Merging... |
dirk-thomas
pushed a commit
to colcon/colcon-core
that referenced
this pull request
May 4, 2020
* Allow ignore_marker to be a dangling symlink As per ros-infrastructure/rep#256 * os.path.lexists instead of (nonexistent) pathlib.path.lexists
prajakta-gokhale
pushed a commit
to colcon/colcon-bundle
that referenced
this pull request
May 13, 2020
* Respect ignore marker even if dangling symlink As per ros-infrastructure/rep#256 * os.path.lexists instead of (nonexistent) pathlib.path.lexists Co-authored-by: Prajakta Gokhale <prajaktg@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mention that CATKIN_IGNORE may be any type of file and its contents are ignored