Remove check of source files done in lint hook

[Blast545]

As the title says, this will close #237. The comment was reworded as well to "source files" as this distinction is made on the ament_copyright linter.

Signed-off-by: Jorge Perez jjperez@ekumenlabs.com

[hidmic]

@Blast545 would it make sense to add LICENSE and CONTRIBUTING.md to the glob list instead of removing it entirely?

[Blast545]

@hidmic That would imply the linter will skip checking a package if it doesn't have a LICENSE/CONTRIBUTING.md file and I think it's desirable to report the failure when those files are not available.

As an added benefit, this will allow having the definition of "source files" only in the linter.

[Blast545]

This will cause build problems with spdlog_vendor and console_bridge_vendor packages that added the ament_copyright linter an extra time. I will remove these extra additions before merging this.

Reference failing build for spdlog_vendor

• Linux

[Blast545]

CI:

• Linux
• Linux-aarch64
• macOS
• Windows

[dirk-thomas]

It would have been good to mention "copyright" in the title since that is being used in the squashed commit message.

[dirk-thomas]

@Blast545 It seems this change is responsible for multiple new copyright test failures in the nighty jobs. Please fix asap.