Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra copyright linter test added #12

Merged
merged 1 commit into from
May 15, 2020

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented May 15, 2020

The extra copyright added at #10 colides with the proposed fix to ament_lint proposed at ament_lint#247.

Signed-off-by: Jorge Perez jjperez@ekumenlabs.com

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 requested a review from brawner May 15, 2020 18:56
Copy link
Contributor

@brawner brawner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me pending CI test with the other PRs.

@Blast545
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Blast545 Blast545 requested a review from brawner May 15, 2020 19:20
@Blast545 Blast545 merged commit ba0d315 into master May 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the blast545/remove_extra_copyright branch May 15, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants