Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop trailing tab from package manifests #291

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Conversation

cottsay
Copy link
Contributor

@cottsay cottsay commented Jan 20, 2021

Follow-up to #274

Follow-up to 8bf194a

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay added the in review Waiting for review (Kanban column) label Jan 20, 2021
@cottsay cottsay self-assigned this Jan 20, 2021
Copy link
Contributor

@claireyywang claireyywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Thanks for fixing it. LGTM!

@cottsay cottsay merged commit 6384a5e into master Jan 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the cottsay/trailing_tab branch January 25, 2021 18:36
kenji-miyake pushed a commit to kenji-miyake/ament_lint that referenced this pull request Oct 20, 2021
Follow-up to 58cc437

Signed-off-by: Scott K Logan <logans@cottsay.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants