Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake linter default line length differs depending on invocation #301

Closed
emersonknapp opened this issue Feb 26, 2021 · 1 comment · Fixed by #306
Closed

CMake linter default line length differs depending on invocation #301

emersonknapp opened this issue Feb 26, 2021 · 1 comment · Fixed by #306
Assignees
Labels
help wanted Extra attention is needed

Comments

@emersonknapp
Copy link
Contributor

emersonknapp commented Feb 26, 2021

This means that, given no external configurations, calling the same tool two ways can have different results. Not sure what the best way to resolve this is - my first thought is to add a default=140 to the ArgumentParser - and to remove the CMake default to avoid duplicate information

david-prody added a commit to david-prody/action-ros-lint that referenced this issue Mar 2, 2021
This resolves the discrepency between the line lenght used during the package
builds and the line length used by this action.

Workaround for this ament issue: ament/ament_lint#301
david-prody added a commit to david-prody/action-ros-lint that referenced this issue Mar 3, 2021
This resolves the discrepency between the line lenght used during the package
builds and the line length used by this action.

Workaround for this ament issue: ament/ament_lint#301

Signed-off-by: Prody <prodyd@amazon.com>
emersonknapp pushed a commit to david-prody/action-ros-lint that referenced this issue Mar 5, 2021
This resolves the discrepency between the line lenght used during the package
builds and the line length used by this action.

Workaround for this ament issue: ament/ament_lint#301

Signed-off-by: Prody <prodyd@amazon.com>
emersonknapp pushed a commit to ros-tooling/action-ros-lint that referenced this issue Mar 5, 2021
This resolves the discrepency between the line lenght used during the package
builds and the line length used by this action.

Workaround for this ament issue: ament/ament_lint#301

Signed-off-by: Prody <prodyd@amazon.com>
@audrow
Copy link
Contributor

audrow commented Mar 12, 2021

my first thought is to add a default=140 to the ArgumentParser - and to remove the CMake default to avoid duplicate information

That sounds good to me. If you want to open a PR for this, feel free to @ me as a reviewer.

@audrow audrow self-assigned this Mar 12, 2021
@audrow audrow added the help wanted Extra attention is needed label Mar 12, 2021
IoriK1020 added a commit to IoriK1020/action-ros-lint that referenced this issue Apr 27, 2024
This resolves the discrepency between the line lenght used during the package
builds and the line length used by this action.

Workaround for this ament issue: ament/ament_lint#301

Signed-off-by: Prody <prodyd@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants