-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake linter default line length differs depending on invocation #301
Labels
help wanted
Extra attention is needed
Comments
david-prody
added a commit
to david-prody/action-ros-lint
that referenced
this issue
Mar 2, 2021
This resolves the discrepency between the line lenght used during the package builds and the line length used by this action. Workaround for this ament issue: ament/ament_lint#301
david-prody
added a commit
to david-prody/action-ros-lint
that referenced
this issue
Mar 3, 2021
This resolves the discrepency between the line lenght used during the package builds and the line length used by this action. Workaround for this ament issue: ament/ament_lint#301 Signed-off-by: Prody <prodyd@amazon.com>
emersonknapp
pushed a commit
to david-prody/action-ros-lint
that referenced
this issue
Mar 5, 2021
This resolves the discrepency between the line lenght used during the package builds and the line length used by this action. Workaround for this ament issue: ament/ament_lint#301 Signed-off-by: Prody <prodyd@amazon.com>
emersonknapp
pushed a commit
to ros-tooling/action-ros-lint
that referenced
this issue
Mar 5, 2021
This resolves the discrepency between the line lenght used during the package builds and the line length used by this action. Workaround for this ament issue: ament/ament_lint#301 Signed-off-by: Prody <prodyd@amazon.com>
That sounds good to me. If you want to open a PR for this, feel free to @ me as a reviewer. |
IoriK1020
added a commit
to IoriK1020/action-ros-lint
that referenced
this issue
Apr 27, 2024
This resolves the discrepency between the line lenght used during the package builds and the line length used by this action. Workaround for this ament issue: ament/ament_lint#301 Signed-off-by: Prody <prodyd@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ament_lint_cmake
entrypoing from shell - defaults to 80 chars from https://github.com/ament/ament_lint/blob/master/ament_lint_cmake/ament_lint_cmake/cmakelint.py#L87ament_cmake_lint_cmake
to callament_lint_cmake()
fromCMakeLists.txt
- it defaults to 140 chars because of https://github.com/ament/ament_lint/blob/master/ament_cmake_lint_cmake/cmake/ament_lint_cmake.cmake#L44This means that, given no external configurations, calling the same tool two ways can have different results. Not sure what the best way to resolve this is - my first thought is to add a
default=140
to the ArgumentParser - and to remove the CMake default to avoid duplicate informationThe text was updated successfully, but these errors were encountered: