Set linelength to 140 for lint action. #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-prody
requested review from
Karsten1987 and
prajakta-gokhale
and removed request for
a team
emersonknapp
approved these changes
Mar 2, 2021
|
Do we know what's going on with this failed check? |
|
Cloudwatxh logging doesn't work from forks because they do not have the same secrets set. It's fine though, it's not a required check. |
This resolves the discrepency between the line lenght used during the package builds and the line length used by this action. Workaround for this ament issue: ament/ament_lint#301 Signed-off-by: Prody <prodyd@amazon.com>
christophebedard
added a commit
to christophebedard/action-ros-lint
that referenced
this pull request
Mar 15, 2021
This reverts commit 8f57e31.
christophebedard
added a commit
to christophebedard/action-ros-lint
that referenced
this pull request
Mar 15, 2021
This reverts commit 8f57e31, but it updates the dist/index.js file. Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
emersonknapp
pushed a commit
that referenced
this pull request
Mar 17, 2021
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the discrepency between the line lenght used during the package
builds and the line length used by this action.
Workaround for this ament issue: ament/ament_lint#301