-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set linelength to 140 for lint action. #246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but you'll need to update your commits with the --signoff
option to pass the DCO check. You can do that with git commit --amend --signoff
(since you only have the single commit) then force push
Do we know what's going on with this failed check?
|
Cloudwatxh logging doesn't work from forks because they do not have the same secrets set. It's fine though, it's not a required check. |
This resolves the discrepency between the line lenght used during the package builds and the line length used by this action. Workaround for this ament issue: ament/ament_lint#301 Signed-off-by: Prody <prodyd@amazon.com>
This reverts commit 8f57e31.
This reverts commit 8f57e31, but it updates the dist/index.js file. Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
This resolves the discrepency between the line lenght used during the package
builds and the line length used by this action.
Workaround for this ament issue: ament/ament_lint#301