Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set linelength to 140 for lint action. #246

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

david-prody
Copy link
Contributor

This resolves the discrepency between the line lenght used during the package
builds and the line length used by this action.

Workaround for this ament issue: ament/ament_lint#301

@david-prody david-prody requested a review from a team as a code owner March 2, 2021 22:59
@david-prody david-prody requested review from Karsten1987 and prajakta-gokhale and removed request for a team March 2, 2021 22:59
Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but you'll need to update your commits with the --signoff option to pass the DCO check. You can do that with git commit --amend --signoff (since you only have the single commit) then force push

@jikawa-az
Copy link

Do we know what's going on with this failed check?

/usr/bin/docker exec  982e37921c6fb4e16a6ddcd0a27070083073b816e57bf10068376ec5d51bc940 sh -c "cat /etc/*release | grep ^ID"
Error: Input required and not supplied: aws-region

@emersonknapp
Copy link
Contributor

Cloudwatxh logging doesn't work from forks because they do not have the same secrets set. It's fine though, it's not a required check.

This resolves the discrepency between the line lenght used during the package
builds and the line length used by this action.

Workaround for this ament issue: ament/ament_lint#301

Signed-off-by: Prody <prodyd@amazon.com>
@emersonknapp emersonknapp merged commit 8f57e31 into ros-tooling:master Mar 5, 2021
christophebedard added a commit to christophebedard/action-ros-lint that referenced this pull request Mar 15, 2021
christophebedard added a commit to christophebedard/action-ros-lint that referenced this pull request Mar 15, 2021
This reverts commit 8f57e31,
but it updates the dist/index.js file.

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
emersonknapp pushed a commit that referenced this pull request Mar 17, 2021
This reverts commit 8f57e31,
but it updates the dist/index.js file.

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants