use Python 3 for cpplint and split into Python and CMake package #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| def test_pep257(): | ||
| excluded = ['ament_cpplint/cpplint.py'] |
There was a problem hiding this comment.
Just wondering, why does this test exclude ament_cpplint/cpplint.py while the others just exclude cpplint.py? Are they all supposed to be the same path?
There was a problem hiding this comment.
Different tools, different API 😉
|
+1 |
dirk-thomas
added a commit
that referenced
this pull request
Nov 7, 2015
use Python 3 for cpplint and split into Python and CMake package
kenji-miyake
referenced
this pull request
in kenji-miyake/ament_lint
Oct 20, 2021
use Python 3 for cpplint and split into Python and CMake package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the pending PR from cpplint for Python 3 compatibility: google/styleguide#47
Fixes ament_cpplint on OS X and Windows: