Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude files or directories in cpplint.py #238

Closed
wants to merge 18 commits into from
Closed

Exclude files or directories in cpplint.py #238

Changes from 2 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
00f5c9e
Exclude files or directories in cpplint.py
ahcorde May 11, 2020
b9f07a6
Removed comments
ahcorde May 12, 2020
06b5d7d
Merge remote-tracking branch 'origin/master' into ahcorde/cpplint/exc…
ahcorde May 14, 2020
9b2b49d
Fixed style in comprehension list
ahcorde May 14, 2020
c04f091
Fixed default value
ahcorde May 15, 2020
e3f3c66
Fixed args name and logic
ahcorde May 18, 2020
e52eff3
Merge remote-tracking branch 'origin/master' into ahcorde/cpplint/exc…
ahcorde May 26, 2020
63d09b5
Improved logic
ahcorde May 26, 2020
66ed86b
Improved logic
ahcorde Jun 10, 2020
5bed967
Fixed comparison with filename
ahcorde Jun 10, 2020
31ea18d
Improved logic
ahcorde Jun 12, 2020
3b9b453
Moved logic to get_file_groups
ahcorde Jun 16, 2020
96395b4
Improved logic
ahcorde Jun 17, 2020
8c0120f
filters dirnames based on the excludes
ahcorde Jun 18, 2020
201486a
remove unnecessary loop and removed excludes from dirnames
ahcorde Jun 22, 2020
218421c
excluded dirname if it is in the excludes
ahcorde Jul 9, 2020
d95c5b3
added dirpath to the dirnames to check
ahcorde Jul 10, 2020
6db3ae3
Improved logic
ahcorde Jul 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ament_cpplint/ament_cpplint/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ def main(argv=sys.argv[1:]):
parser.add_argument(
'--root', type=str,
help='The --root option for cpplint')
parser.add_argument(
'--exclude', default=[''],
dirk-thomas marked this conversation as resolved.
Show resolved Hide resolved
nargs='*',
help='Exclude directories or C/C++ files to be checked.')
parser.add_argument(
'paths',
nargs='*',
Expand Down Expand Up @@ -144,7 +148,8 @@ def main(argv=sys.argv[1:]):
else:
print("Not using '--root'")
print('')
arguments += files
arguments += [file for file in files
dirk-thomas marked this conversation as resolved.
Show resolved Hide resolved
if any(excl not in file or not excl for excl in args.exclude)]
dirk-thomas marked this conversation as resolved.
Show resolved Hide resolved
dirk-thomas marked this conversation as resolved.
Show resolved Hide resolved
filenames = ParseArguments(arguments)

for filename in filenames:
Expand Down