Fix exclude regression #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: methylDragon <methylDragon@gmail.com>
This was referenced Jun 9, 2022
|
Demonstration of fix, with flake8 lint errors in
|
methylDragon
force-pushed
the
ch3/fix_exclude_regression
branch
2 times, most recently
from
1a9e4ab
to
6915bc6
Compare
|
Single quotes!! ✊ ✊ ✊ |
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
ch3/fix_exclude_regression
branch
from
6915bc6
to
b9c8f3f
Compare
|
Unstable windows build is unrelated to this PR |
aprotyas
approved these changes
Jun 11, 2022
ament_flake8/ament_flake8/main.py
Outdated
| def parse_config_file(config_file): | ||
| from flake8.options import config, manager, aggregator | ||
|
|
||
| opts_manager = manager.OptionManager(prog='flake8', version='3.0.0') |
There was a problem hiding this comment.
Why 3.x? In Ubuntu 22.04 the default flake8 version is 4.x.
|
I've reordered the try-except. Testing on both jammy and focal since it matters due to the API breaking change for flake8. Jammy:
Focal:
|
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
ch3/fix_exclude_regression
branch
from
3bf3ed3
to
5a5d913
Compare
|
Unstable focal aarch64 build is unrelated to this PR |
emersonknapp
pushed a commit
to emersonknapp/ament_lint
that referenced
this pull request
Sep 14, 2023
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
pushed a commit
to emersonknapp/ament_lint
that referenced
this pull request
Sep 14, 2023
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
clalancette
added a commit
that referenced
this pull request
Sep 20, 2023
#451) * Fix exclude regression (#387) * Fix compatibility with flake8 version 5 (#410) * Fix compatibility with flake8 version 5 The ConfigFileFinder class no longer exists in flake8 version 5. The get_style_guide() code has been updated from the latest api.legacy.get_style_guide() in flake8. Signed-off-by: Timo Röhling <roehling@debian.org> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> Co-authored-by: methylDragon <methylDragon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #382 by explicitly adding any exclude args in the flake8 config file (normally
configuration/ament_flake8.ini) to the exclude arglist.Notably, this uses the same parsing logic that the version of flake8 ROS is using on focal and jammy (3.9.7 and 4.0.0).
I tried to account for differences in the parsing logic between 3.9.7 and 4.0.0 with a try except clause.