This repository has been archived by the owner on Feb 4, 2020. It is now read-only.
use CTest BUILD_TESTING #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,8 +93,7 @@ def on_build(self, context): | |||
| # Calculate any extra cmake args which are not common between cmake build types | |||
| extra_cmake_args = [] | |||
| if should_run_configure: | |||
| if context.build_tests: | |||
| extra_cmake_args += ["-DAMENT_ENABLE_TESTING=1"] | |||
| extra_cmake_args += ["-DBUILD_TESTING=%d" % int(context.build_tests)] | |||
There was a problem hiding this comment.
This is a bit of a behavior change (previously building with --build-tests and then omitting it would not "undo" the building of tests), but it looks ok to me.
There was a problem hiding this comment.
The problem is that before we didn't know when it was intentional and when it was not. I think the new behavior is more consistent - you get what you specify.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect to ament/ament_cmake#68