Update google_benchmark to v1.5.3 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Change google_benchmark version from v1.5.2 to v1.5.3. Because v1.5.2 can not build with GCC 11 2. Removed shrink-tz-offset-size.patch because of this patch was merged in google-benchmark repo. Signed-off-by: Homalozoa <nx.tardis@gmail.com>
|
Let's run CI with this and see how it looks:
|
|
I think that the CMake warnings on aarch64 and Windows are expected for the performance benchmarks, but I'm not sure. @cottsay Could you take a look at this PR and the CI run and see if it makes sense to you? |
Yes, those warnings are expected with |
Thanks, appreciated. Then I'll go ahead and merge this. |
clalancette
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can not build with GCC 11
google-benchmark repo.
Signed-off-by: Homalozoa nx.tardis@gmail.com