Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

fix(createBrowserLikeFetch): skip malformed header cookies #19

Merged
merged 1 commit into from
May 20, 2021

Conversation

PixnBits
Copy link
Contributor

Description

drop cookie values that could not be parsed

Motivation and Context

When a request cookie could not be parsed the parser returns undefined, this causes other issues like property access.

Cannot read property 'key' of undefined

for parsedCookie.key

How Has This Been Tested?

tests included

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • This change adds additional environment variable requirements for fetch-enhancers users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using fetch-enhancers?

no impact

@PixnBits PixnBits requested a review from a team as a code owner May 14, 2021 18:35
@PixnBits PixnBits merged commit ff9377a into main May 20, 2021
@PixnBits PixnBits deleted the fix/skip-malformed-cookies-from-headers branch May 20, 2021 21:20
oneamexbot added a commit that referenced this pull request May 20, 2021
## [1.1.1](v1.1.0...v1.1.1) (2021-05-20)

### Bug Fixes

* **createBrowserLikeFetch:** skip malformed header cookies ([#19](#19)) ([ff9377a](ff9377a))
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants