Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce distribution size #294

Closed
neurolabusc opened this issue Mar 27, 2022 · 3 comments · Fixed by #307
Closed

Reduce distribution size #294

neurolabusc opened this issue Mar 27, 2022 · 3 comments · Fixed by #307
Labels

Comments

@neurolabusc
Copy link

Running npm install jest-image-snapshot takes a long time for slow connections and takes up a lot of disk space. The reason is the 2.9mb of files in the images folder that are linked in the README.md github description. Is there any way these penalties could be reduced, e.g. with a demo that only has a few images, links to images at a separate URL (e.g. the images have not been changed in four years). Given the popularity of this tool, it would be considerate if the installation time and size could be optimized.

@anescobar1991
Copy link
Member

You could probably open a pull request to update the URLs in the README to point to the raw image URL (something like https://raw.githubusercontent.com/americanexpress/jest-image-snapshot/main/images/create-snapshot.gif) and also add images to the .npmignore file?

@JAdshead thoughts? The only thing I don't like but don't think is a dealbreaker is the branch name being hardcoded in the URL but these have not changed since I first added them 4 years ago so...

@JAdshead
Copy link
Contributor

I think that would be fine. including them in the .npmignore might be sufficient

@oneamexbot
Copy link
Contributor

🎉 This issue has been resolved in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

goverdhan07 pushed a commit to goverdhan07/jest-image-snapshot that referenced this issue Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants