Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: windows & mac #342

Merged
merged 5 commits into from
Oct 5, 2023
Merged

ci: windows & mac #342

merged 5 commits into from
Oct 5, 2023

Conversation

LeoDog896
Copy link
Contributor

@LeoDog896 LeoDog896 commented Sep 30, 2023

Description

This PR adds a matrix to run the CI on Windows, Mac, and Linux, and fixes a broken test on windows because of a different path name

Motivation and Context

To stop operating system regressions and allow for testing the repository in a Windows development environment.

Types of Change

  • Testing change

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I added the Apache 2.0 license header to any new files.

What is the Impact on Developers Using Jest-Image-Snapshot?

Very little - this stops possible regressions in path systems, as what happened with privatenumber/pkgroll#10

LeoDog896 and others added 2 commits October 3, 2023 18:58
Co-authored-by: Jonny Adshead <JAdshead@users.noreply.github.com>
Co-authored-by: Jonny Adshead <JAdshead@users.noreply.github.com>
@Matthew-Mallimo Matthew-Mallimo merged commit 819163e into americanexpress:main Oct 5, 2023
10 checks passed
@Matthew-Mallimo
Copy link
Member

Thank you!

@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 6.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants