fix(one-app-runner): include legacy bundle on serve-module even if it…

… does not exist (#629)
americanexpress · Mar 26, 2024 · f48ef4f · f48ef4f
1 parent 05c80cd
commit f48ef4f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 10 deletions.
diff --git a/packages/one-app-server-bundler/__tests__/bin/__snapshots__/serve-module.spec.js.snap b/packages/one-app-server-bundler/__tests__/bin/__snapshots__/serve-module.spec.js.snap
@@ -36,7 +36,7 @@ exports[`serve-module adds to the existing module map 1`] = `
 }"
 `;
 
-exports[`serve-module adds to the existing module map without legacy when legacy bundle does not exist 1`] = `
+exports[`serve-module adds to the existing module map with a warning in place of the legacy browser SRI when legacy bundle does not exist 1`] = `
 "{
   \\"key\\": \\"--- omitted for development ---\\",
   \\"modules\\": {
@@ -58,6 +58,10 @@ exports[`serve-module adds to the existing module map without legacy when legacy
       \\"node\\": {
         \\"integrity\\": \\"123\\",
         \\"url\\": \\"[one-app-dev-cdn-url]/static/modules/my-module-name/1.0.0/my-module-name.node.js\\"
+      },
+      \\"legacyBrowser\\": {
+        \\"integrity\\": \\"[No legacy bundle generated for my-module-name. This will 404.]\\",
+        \\"url\\": \\"[one-app-dev-cdn-url]/static/modules/my-module-name/1.0.0/my-module-name.legacy.browser.js\\"
       }
     }
   }

diff --git a/packages/one-app-server-bundler/__tests__/bin/serve-module.spec.js b/packages/one-app-server-bundler/__tests__/bin/serve-module.spec.js
@@ -152,7 +152,7 @@ describe('serve-module', () => {
     expect(fs._.getFiles()['/mocked/static/module-map.json']).toMatchSnapshot();
   });
 
-  it('adds to the existing module map without legacy when legacy bundle does not exist', () => {
+  it('adds to the existing module map with a warning in place of the legacy browser SRI when legacy bundle does not exist', () => {
     process.env.NODE_ENV = 'development';
     fs._.setFiles({
       '../my-module-name/package.json': JSON.stringify({ name: 'my-module-name', version: '1.0.0' }),

diff --git a/packages/one-app-server-bundler/bin/serve-module.js b/packages/one-app-server-bundler/bin/serve-module.js
@@ -65,7 +65,7 @@ util.parseArgs({ allowPositionals: true }).positionals.forEach((modulePath) => {
     fs.writeFileSync(moduleMapPath, JSON.stringify({ key: 'not-used-in-development', modules: {} }, null, 2));
   } finally {
     const moduleMap = JSON.parse(fs.readFileSync(moduleMapPath));
-    const generalConfig = {
+    moduleMap.modules[moduleName] = {
       browser: {
         integrity: browserSri,
         url: `[one-app-dev-cdn-url]/static/modules/${moduleName}/${version}/${moduleName}.browser.js`,
@@ -74,16 +74,11 @@ util.parseArgs({ allowPositionals: true }).positionals.forEach((modulePath) => {
         integrity: nodeSri,
         url: `[one-app-dev-cdn-url]/static/modules/${moduleName}/${version}/${moduleName}.node.js`,
       },
-    };
-
-    const legacyConfig = legacyBrowserSri ? {
       legacyBrowser: {
-        integrity: legacyBrowserSri,
+        integrity: legacyBrowserSri || `[No legacy bundle generated for ${moduleName}. This will 404.]`,
         url: `[one-app-dev-cdn-url]/static/modules/${moduleName}/${version}/${moduleName}.legacy.browser.js`,
       },
-    } : {};
-
-    moduleMap.modules[moduleName] = { ...generalConfig, ...legacyConfig };
+    };
 
     fs.writeFileSync(moduleMapPath, JSON.stringify(moduleMap, null, 2));
   }