Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

fix(one-app-server-bundler): include legacy bundle on serve-module even if it does not exist #629

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

10xLaCroixDrinker
Copy link
Member

@10xLaCroixDrinker 10xLaCroixDrinker commented Mar 26, 2024

Description

Always include a legacy bundle entry in module map

Motivation

Serving modules without legacy bundles caused dev cdn to choke

Test Conditions

  • Updated unit
  • Manually validated running serve-module

Types of changes

Check boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist

Check boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

@10xLaCroixDrinker 10xLaCroixDrinker merged commit f48ef4f into main Mar 26, 2024
6 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the bugfix/serve-module branch March 26, 2024 18:33
@10xLaCroixDrinker 10xLaCroixDrinker changed the title fix(one-app-runner): include legacy bundle on serve-module even if it does not exist fix(one-app-server-bundler): include legacy bundle on serve-module even if it does not exist Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants