This repository has been archived by the owner on May 15, 2024. It is now read-only.
fix(styles-loader): hash css module classes from files in node_modules #613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
There are two core issues here: deviation from the spec of css modules, and inconsistent behavior between the dev and prod bundler.
When a css file ends in
.module.css
, this is an indication from the writer of the css that the classes within it should definitely be hashed. In #124, a change was introduced (specifically in the production bundler) that caused any css files imported from withinnode_modules
to not be hashed. Since this change makes no distinction between files ending in.css
and.module.css
, any css file (including css modules) will result in classes not being hashed.Additionally, since #124 was introduced this change was not carried over into the dev bundler. This meant that your application would result in different classes depending on which bundler was being used.
Test Conditions
Types of changes
Check boxes that apply:
Checklist