Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

fix(css-loader): do not use localName for css modules in node_modules #617

Merged

Conversation

zacowan
Copy link
Member

@zacowan zacowan commented Mar 7, 2024

Description

Port of #613 to v6 of one-app-bundler.

Motivation

See #613 for original motivation.

Test Conditions

Added unit tests to validate that css modules do not use localName.

Additionally, validated the change locally by bundling a one app module, which uses a dependency that imports css modules, using the webpack-based bundler.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

@Matthew-Mallimo Matthew-Mallimo merged commit 7d112aa into @americanexpress/one-app-bundler@6.x.x Mar 19, 2024
5 checks passed
@Matthew-Mallimo Matthew-Mallimo deleted the fix/hash-css-modules branch March 19, 2024 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants