allow :latest when specifying image tag

[agorskiy12]

allow to use :latest when specifying image tag

Provide a general summary of your changes in the Title above.

Description

:latest should be allowed when specifying image tag

Types of changes

Check boxes that apply:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation (adding or updating documentation)
• Dependency update
• Security update

Checklist

Check boxes that apply:

• My code follows the code style of this project.
• My change requires a change to the documentation and I have updated the documentation accordingly.
• These changes should be applied to a maintenance branch.
• I have added the Apache 2.0 license header to any new files created.

[10xLaCroixDrinker]

Suggested change

	if (appVersion === 'latest' ? true : semver.intersects(appVersion, '^5.13.0', { includePrerelease: true })) {
	if (appVersion === 'latest' || semver.intersects(appVersion, '^5.13.0', { includePrerelease: true })) {

We could avoid the ternary, but its not a blocker

[agorskiy12]

actually, now that I think about it, the reason I added ternary was because I kept getting this error with the or operator:

Invalid comparator: latest ,

it seems that semver.intersects doesnt like "latest". So, reverting back to my original code that avoids semver when latest is specified.

[Matthew-Mallimo]

@agorskiy12 Can you also test for when :6 is provided? @smackfu had mentioned that its failing a check for that as well. We should be adding the flags for one-app versions >=6.6.0

[agorskiy12]

@agorskiy12 Can you also test for when :6 is provided? @smackfu had mentioned that its failing a check for that as well. We should be adding the flags for one-app versions >=6.6.0

OK I'll check for that.

are you saying we should ONLY be adding flags for versions >=6.6.0 ? Could you elaborate why? right now we're allowing anything after 5.13.0

[Matthew-Mallimo]

@agorskiy12 Can you also test for when :6 is provided? @smackfu had mentioned that its failing a check for that as well. We should be adding the flags for one-app versions >=6.6.0

OK I'll check for that.

are you saying we should ONLY be adding flags for versions >=6.6.0 ? Could you elaborate why? right now we're allowing anything after 5.13.0

>=5.13.0 and >=6.6.0 are on Node 18, where these flags are needed. Anything prior to those versions are on Node 16 where these flags dont exist

[agorskiy12]

@agorskiy12 Can you also test for when :6 is provided? @smackfu had mentioned that its failing a check for that as well. We should be adding the flags for one-app versions >=6.6.0

OK I'll check for that.
are you saying we should ONLY be adding flags for versions >=6.6.0 ? Could you elaborate why? right now we're allowing anything after 5.13.0

>=5.13.0 and >=6.6.0 are on Node 18, where these flags are needed. Anything prior to those versions are on Node 16 where these flags dont exist

OK i see. I also see why something like 6.6.0 wouldnt work -

caret ^ means any version compatible, but anything with 6 will not "intersect" because theres a major version change from 5.

we will have to use something like semver.gte (greater than).