Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

allow :latest and versions >=6.6.0 when specifying image tag #628

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

agorskiy12
Copy link
Contributor

@agorskiy12 agorskiy12 commented Mar 26, 2024

Description

:latest should be allowed when specifying image tag . also need to support versions >=6.6.0

Types of changes

Check boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist

Check boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

Copy link
Member

@smackfu smackfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some opportunity to clean up the test duplication but not going to hold this up since the latest runner is broken when running with one-app v6.

@10xLaCroixDrinker 10xLaCroixDrinker merged commit 82d33e0 into main Mar 26, 2024
5 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the fix/image-version-allow-latest branch March 26, 2024 18:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants