-
Notifications
You must be signed in to change notification settings - Fork 84
Conversation
d0e85cb
to
8f9c95f
Compare
📊 Bundle Size Report
|
@@ -29,6 +29,7 @@ | |||
"test:lockfile": "lockfile-lint -p package-lock.json -t npm -a npm -o https: -c -i", | |||
"test:lint": "eslint --ext js,jsx,md,snap .", | |||
"start": "node lib/server/index.js", | |||
"start:inspect": "node --inspect --expose-gc lib/server/index.js", | |||
"test:unit": "jest --testPathIgnorePatterns integration --config jest.config.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No convenient npm script for this functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this gives us that npm run start:inspect
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm run serve:prod-sample-module ../some-test-module
?
await fs.ensureDir(pathToOriginModuleStatics); | ||
await fs.copy(pathToModuleBuildDir, pathToOriginModuleStatics, { overwrite: true }); | ||
return pathToOriginModuleStatics; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this update while the local production server is running?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it will
moduleName, | ||
moduleVersion, | ||
envVars: sanitizedEnvVars, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed to override the development build created after install?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this ensures the build is run with NODE_ENV=production
https://github.com/americanexpress/one-app/pull/308/files#diff-db5dfce483b0c43f844c909e42e27356R72
Co-authored-by: Mike Tobia <Francois-Esquire@users.noreply.github.com>
Description
This adds a util script for deploying modules to
prod-sample
.Motivation and Context
To aid testing modules running in production
How Has This Been Tested?
Locally served modules to
prod-sample
Types of Changes
Checklist:
What is the Impact to Developers Using One App?