This repository has been archived by the owner on May 3, 2024. It is now read-only.
refactor(deps): remove ip for node native implementation #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 719 kB ℹ️ View Unchanged
|
giulianok
reviewed
Feb 26, 2024
giulianok
reviewed
Feb 26, 2024
giulianok
reviewed
Feb 26, 2024
giulianok
suggested changes
Feb 26, 2024
giulianok
suggested changes
Feb 26, 2024
| @@ -252,5 +252,5 @@ const runTime = [ | |||
| }, | |||
| ]; | |||
| runTime.forEach(preprocessEnvVar); | |||
| export { ip }; | |||
There was a problem hiding this comment.
ip is actually a string but we return a function, should we return the function call?
Matthew-Mallimo
approved these changes
Feb 28, 2024
giulianok
reviewed
Feb 28, 2024
|
|
||
| const ipAddresses = Object.keys(interfaces) | ||
| .map((name) => interfaces[name].find((iface) => iface.family === 'IPv4' | ||
| && !iface.internal && iface.address !== '127.0.0.1')) |
There was a problem hiding this comment.
not a blocker but && iface.address !== '127.0.0.1' is no longer needed
giulianok
approved these changes
Feb 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove node package 'Ip' use node native implementation in order to provide the same functionality
Motivation and Context
How Has This Been Tested?
unit tests, built local docker image
Types of Changes
Checklist:
What is the Impact to Developers Using One App?