Adds test #15
Merged
Adds test #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdougie
commented
Jan 4, 2017
| it('renders without crashing', () => { | ||
| const wrapper = shallow (<List vendor={dummyVendor} />); | ||
| expect(wrapper).toExist; | ||
| }); |
There was a problem hiding this comment.
This is the test, let me know if you have any questions
|
@americool sorry this took so long. I kept trying to rebase and getting distracted by something else at work. This is now mergeable, go ahead and review and then merge here. Also write identical tests for all components in src and let me know if you have questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a few commits to add the first test to the project, we can chat about it tomorrow.
I did have to create a
test/setup.jsfile because ofreact-native-router-fluxnot respecting the react-native-mock library. This seems like a good opportunity to get an open source contribution.facebook/react-native#11585
We can talk more about this IRL