Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Successfully testing #75

Merged
merged 8 commits into from
May 4, 2017
Merged

Successfully testing #75

merged 8 commits into from
May 4, 2017

Conversation

tobyapi
Copy link
Contributor

@tobyapi tobyapi commented May 4, 2017

I changed the code to pass all testing:

  • remove default argument of app_path #74
  • replace Void by Nil
  • use perfect matching for route matching
    • so "/indexsd" does not match "/index"
  • remove package name from klass_name (klass_name is Amethyst::IndexController)

@Codcore
Copy link
Collaborator

Codcore commented May 4, 2017

@TobiasGSmollett oh, good work,thanks!

@Codcore Codcore merged commit 6f80cce into amethyst-framework:master May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobyapi @Codcore