This repository has been archived by the owner on Apr 18, 2022. It is now read-only.
WASM: Support loading assets for GL backend #2174
Labels
feat: WASM support
This issue is related to WebAssembly compilation target support
Projects
Comments
azriel91
added
status: ready
feat: WASM support
7 tasks
bors bot
added a commit
that referenced
this issue
Mar 24, 2020
2189: WASM: make it possible to run pong_wasm r=azriel91 a=chemicstry ## Description Minimum workarounds to get wasm running. Issues that need proper fix: - `shred` is patched to be singlethreaded, need to resolve main thread synchronisation. - #2174 is resolved by `add_thread_local`. Does that move too much processing to the main thread? - Audio crashes on wasm. - UI crashes on wasm. Other: - Need to move `web_worker` to amethyst and apply latest commit. ## PR Checklist By placing an x in the boxes I certify that I have: - [ ] Updated the content of the book if this PR would make the book outdated. - [ ] Added a changelog entry if this will impact users, or modified more than 5 lines of Rust that wasn't a doc comment. - [ ] Added unit tests for new code added in this PR. - [ ] Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme. If this modified or created any rs files: - [ ] Ran `cargo +stable fmt --all` - [ ] Ran `cargo clippy --all --features "empty"` - [ ] Ran `cargo test --all --features "empty"` Co-authored-by: chemicstry <chemicstry@gmail.com>
|
Partially solved by #2198. Even with that merged, GL backend cannot load texture assets with cargo run --example ui --features "audio gl system_font" # --release |
|
Looks like the remainder is resolved by #2217 (thanks 🙇♂️!) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently, an application compiled using the the
"gl"backend crashes when loading textures.This is because the
Windowis created on one thread, and in open GL the textures must also be loaded on the same thread. However,amethyst_assets'AssetStoragetakes in aThreadPool, and loads assets asynchronously on any thread that picks up the processing task.Code points of interest:
amethyst/amethyst_rendy/src/bundle.rs:121adds aTextureProcessorSystem.amethyst/amethyst_rendy/src/system.rs:230callsprocessonAssetStorage.rendy/resource/src/image.rs:86callsdevice.create_image.gfx/src/backend/gl/src/lib.rs:375asserts the thread IDs are equal.What should succeed:
cargo run --example pong --features "gl audio"The text was updated successfully, but these errors were encountered: