This repository has been archived by the owner on Apr 18, 2022. It is now read-only.
Adds CameraOrthoPrefab #1188
Merged
Adds CameraOrthoPrefab #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnneKitsune
approved these changes
Nov 27, 2018
There was a problem hiding this comment.
Normally you should be able to derive PrefabData for this using the macro. @Rhuagh ?
amethyst_utils/src/ortho_camera.rs
Outdated
| @@ -86,6 +89,35 @@ impl Component for CameraOrtho { | |||
| type Storage = DenseVecStorage<Self>; | |||
| } | |||
|
|
|||
| /// CameraOrtho prefab | |||
There was a problem hiding this comment.
Would be nice to have a tiny bit more doc.
There was a problem hiding this comment.
Heh, I'lll try the derive. Hadn't seen that.
There was a problem hiding this comment.
Do you think it still needs docs if it's just a derive?
azriel91
approved these changes
Nov 27, 2018
AnneKitsune
approved these changes
Nov 28, 2018
mtsr
force-pushed
the
camera_ortho_prefab
branch
2 times, most recently
from
7c1f1d6
to
6fb32ea
Compare
torkleyy
reviewed
Dec 1, 2018
torkleyy
added
type: improvement
|
@mtsr Unfortunately there's a conflict with the changelog (yes, this happens too often, I'll fix it soon). Would you mind rebasing this PR so we can merge it? |
mtsr
force-pushed
the
camera_ortho_prefab
branch
from
6fb32ea
to
753a742
Compare
|
Just rebased it. |
|
Thanks! 👍 bors r=azriel91,jojolepro |
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to be able to set the CameraOrtho world coordinates in a Prefab, so I created a quick CameraOrthoPrefab.