Skip to content
This repository has been archived by the owner on Apr 18, 2022. It is now read-only.

Reword sentence. #1304

Closed
wants to merge 2 commits into from
Closed

Reword sentence. #1304

wants to merge 2 commits into from

Conversation

yuvallanger
Copy link

@yuvallanger yuvallanger commented Jan 1, 2019 •
edited
Loading

To be honest, the wording here is a bit clunky. I don't know what to do.

TimonPost
TimonPost suggested changes Jan 1, 2019
View reviewed changes
Copy link
Member

@TimonPost TimonPost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not a good sentence this might be better:

To make Application aware of the change, and deside to which events the state should be send, you need to supply both the ...

@yuvallanger
Copy link
Author

@TimonPost How about now?

@yuvallanger yuvallanger changed the title Fix typo. Reword sentence. Jan 1, 2019
@AnneKitsune @yuvallanger
Update book/src/concepts/state.md
99e316b 
Co-Authored-By: yuvallanger <yuval.langer@gmail.com>
@yuvallanger
Copy link
Author

yuvallanger commented Jan 1, 2019 •
edited
Loading

I just accepted(?) @Jojolepro's suggestion. Did anything explode? Are we safe?

Also, sorry for not accepting your suggestion directly, @TimonPost. This is new to me.

TimonPost
TimonPost approved these changes Jan 1, 2019
View reviewed changes
Copy link
Member

@TimonPost TimonPost left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, for everything is a first time XP. This looks good now.

Moxinilian
Moxinilian approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@Moxinilian Moxinilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

AnneKitsune
AnneKitsune reviewed Jan 2, 2019
View reviewed changes
Copy link
Contributor

@AnneKitsune AnneKitsune left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space somehow appeared at the start of the line. Weird

Looks like I'm at fault here ^u^

@khionu
Copy link
Member

khionu commented Jan 2, 2019

bors +r

@bors
Copy link
Contributor

bors bot commented Jan 2, 2019

Did you mean "r+"?

@khionu
Copy link
Member

khionu commented Jan 2, 2019

bors r+

I'm going to start typing this over and over until I have it in muscle memory.

@Moxinilian
Copy link
Member

@yuvallanger Could you please remove the leading space and squash so we can merge?
bors r-

bors bot added a commit that referenced this pull request Jan 2, 2019
@bors @yuvallanger @AnneKitsune
Merge #1304
e83fe00 
1304: Reword sentence. r=khionu a=yuvallanger

To be honest, the wording here is a bit clunky. I don't know what to do.

Co-authored-by: Yuval Langer <yuval.langer@gmail.com>
Co-authored-by: Joël Lupien <jojolepromain@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 2, 2019

Canceled

@udoprog udoprog added team: documentation type: improvement An improvement or change to an existing feature. status: review comments labels Jan 5, 2019
@yuvallanger yuvallanger mentioned this pull request Jan 6, 2019
Closed
@yuvallanger
Copy link
Author

Closing #1304 and #1311. Will open again after I read the documentation.

@yuvallanger yuvallanger closed this Jan 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AnneKitsune AnneKitsune AnneKitsune left review comments

@khionu khionu khionu approved these changes

@TimonPost TimonPost TimonPost approved these changes

@Moxinilian Moxinilian Moxinilian approved these changes

Assignees
No one assigned
Labels
team: documentation type: improvement An improvement or change to an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yuvallanger @khionu @Moxinilian @AnneKitsune @TimonPost @udoprog