Add Custom Shader Example #1904
Conversation
First compiling version with technicailly a custom shader
Moved to use shader compiler. This requires Ninja on windows.
Does not display yet
updated with discord suggestions
Removed println and profiling
Added color and scale to the shaders and the pass
The triangles can now be scaled with the mouse wheel.
Removed all the warnings from the project
Replaced docs in the custom pass with the correct ones.
Cleaning code with clippy and updated more docs.
Tried to explain what the code in prepare and draw inline do.
Kind of documented the pipeline
Since I am not using precompiled shaders. Remove the directory.
Merge for custom shader example
I forgot to commit this.
Moved from using compiler-shader to precompiled shader. Also updated some comments.
Codecov Report
@@ Coverage Diff @@
## master #1904 +/- ##
==========================================
- Coverage 83.2% 82.39% -0.81%
==========================================
Files 77 79 +2
Lines 5627 5903 +276
==========================================
+ Hits 4682 4864 +182
- Misses 945 1039 +94
Continue to review full report at Codecov.
|
Merge Example readme
Add this example to the examples readme.
Moved to using rust iterators over loops
I always forget this
Moved the code to a doc comment
|
Is this intended to be a custom render pass, or indeed just a custom shader used with builtin 3d passes? Because it is possible to define those without copying the whole pass. I'm going to review it assuming first, but maybe that wasn't the intention. |
The issue linked to https://github.com/amethyst/amethyst-imgui/blob/master/src/pass.rs I based mine on this. It is a custom render pass mostly to show off all of the steps. |
Okay, but then the example is about custom render pass. Naming it as "custom shader" example can be confusing. You don't need to write a whole render pass if you want to just change a shader, because our builtin render passes are generic over shaders and their parameters. |
|
I will change the example name to Custom Render Pass |
Used ChangeDetection based on suggestions in review
implimented Frizi suggestioins
|
bors r=frizi,jaynus |
Merge conflict |
|
bors retry |
1904: Add Custom Shader Example r=frizi,jaynus a=mrhatman ## Description Adds an example that uses a custom shader and render. Any suggestions for code readability and clarity would be greatly appreciated as think is the first renderer I have written. Fixes #1702 ## Additions - Custom Shader Example ## PR Checklist By placing an x in the boxes I certify that I have: - [N/A ] Updated the content of the book if this PR would make the book outdated. - [N/A ] Added a changelog entry if this will impact users, or modified more than 5 lines of Rust that wasn't a doc comment. - [N/A] Added unit tests for new code added in this PR. - [x] Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme. If this modified or created any rs files: - [x] Ran `cargo +stable fmt --all` - [x] Ran `cargo clippy --all --features "empty"` - [x] Ran `cargo test --all --features "empty"` Co-authored-by: mrhatman <lucasince@gmail.com>
Build succeeded |
Description
Adds an example that uses a custom shader and render.
Any suggestions for code readability and clarity would be greatly appreciated as think is the first renderer I have written.
Fixes #1702
Additions
PR Checklist
By placing an x in the boxes I certify that I have:
If this modified or created any rs files:
cargo +stable fmt --allcargo clippy --all --features "empty"cargo test --all --features "empty"