This repository has been archived by the owner on Apr 18, 2022. It is now read-only.
Support targeting multiple entities with UiEvents generated by the MouseUiSystem #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport targeting multiple entities with UiEvents generated by the MouseUiSystem
Codecov Report
@@ Coverage Diff @@
## master #2138 +/- ##
==========================================
- Coverage 83.9% 83.41% -0.49%
==========================================
Files 74 74
Lines 5994 5994
==========================================
- Hits 5029 5000 -29
- Misses 965 994 +29
Continue to review full report at Codecov.
|
azriel91
reviewed
Feb 17, 2020
amethyst_ui/src/event.rs
Outdated
| }); | ||
|
|
||
| let mut first_opaque = None; | ||
| for (i, (_e, t)) in entity_transforms.iter().enumerate() { |
There was a problem hiding this comment.
Perhaps this is clearer:
let first_opaque = entity_transforms.iter().position(|(_e, t)| t.opaque);There was a problem hiding this comment.
Definitely better, thanks!
|
Oops. I think I made a git noob mistake. Not sure why I have duplicate commits. I rebased to amend the first commit. Then I pulled and had to merge. I probably should have just made a new commit. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 17, 2020
2138: Support targeting multiple entities with UiEvents generated by the MouseUiSystem r=azriel91 a=bonsairobo ## Description Support targeting multiple entities with UiEvents generated by the MouseUiSystem ## Additions - Add the `transparent_target: bool` field to `UiTransform` and `UiTransformData`. ## Modifications - Use the field in `ui::events::targeted` to support the desired behavior. ## PR Checklist By placing an x in the boxes I certify that I have: - [ ] Updated the content of the book if this PR would make the book outdated. - [x] Added a changelog entry if this will impact users, or modified more than 5 lines of Rust that wasn't a doc comment. - [ ] Added unit tests for new code added in this PR. - [x] Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme. If this modified or created any rs files: - [x] Ran `cargo +stable fmt --all` - [x] Ran `cargo clippy --all --features "empty"` - [x] Ran `cargo test --all --features "empty"` Co-authored-by: Duncan <bonsairobo@gmail.com>
Build failed |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Feb 17, 2020
2138: Support targeting multiple entities with UiEvents generated by the MouseUiSystem r=azriel91 a=bonsairobo ## Description Support targeting multiple entities with UiEvents generated by the MouseUiSystem ## Additions - Add the `transparent_target: bool` field to `UiTransform` and `UiTransformData`. ## Modifications - Use the field in `ui::events::targeted` to support the desired behavior. ## PR Checklist By placing an x in the boxes I certify that I have: - [ ] Updated the content of the book if this PR would make the book outdated. - [x] Added a changelog entry if this will impact users, or modified more than 5 lines of Rust that wasn't a doc comment. - [ ] Added unit tests for new code added in this PR. - [x] Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme. If this modified or created any rs files: - [x] Ran `cargo +stable fmt --all` - [x] Ran `cargo clippy --all --features "empty"` - [x] Ran `cargo test --all --features "empty"` Co-authored-by: Duncan <bonsairobo@gmail.com>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support targeting multiple entities with UiEvents generated by the MouseUiSystem
Additions
transparent_target: boolfield toUiTransformandUiTransformData.Modifications
ui::events::targetedto support the desired behavior.PR Checklist
By placing an x in the boxes I certify that I have:
If this modified or created any rs files:
cargo +stable fmt --allcargo clippy --all --features "empty"cargo test --all --features "empty"