feat: Add stepping and exact input value control to animation system #569
Conversation
03d8fee
to
6fc5ca1
Compare
Rebased, ready now. |
Reviewed 5 of 5 files at r1. amethyst_animation/src/resources.rs, line 328 at r1 (raw file):
Can you make the Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion. amethyst_animation/src/resources.rs, line 328 at r1 (raw file): Previously, torkleyy (Thomas Schaller) wrote…
Not sure, still need to do edge case handling individually so the index don't overflow/underflow. Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion. amethyst_animation/src/resources.rs, line 328 at r1 (raw file): Previously, Rhuagh (Simon Rönnberg) wrote…
It would remove one line, that's about it. Comments from Reviewable |
r? @Xaeroxe @omni-viral |
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bors r+
569: feat: Add stepping and exact input value control to animation system r=Xaeroxe a=Rhuagh Needs rebase when #567 is merged. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/569) <!-- Reviewable:end -->
Needs rebase when #567 is merged.
This change is