Skip to content
This repository has been archived by the owner on Apr 18, 2022. It is now read-only.

feat: Add stepping and exact input value control to animation system #569

Merged
merged 1 commit into from Feb 13, 2018

Conversation

Rhuagh
Copy link
Member

@Rhuagh Rhuagh commented Feb 11, 2018

Needs rebase when #567 is merged.


This change is Reviewable

@Rhuagh
Copy link
Member Author

Rhuagh commented Feb 12, 2018

Rebased, ready now.

@torkleyy
Copy link
Member

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


amethyst_animation/src/resources.rs, line 328 at r1 (raw file):

/// Used when doing animation stepping (i.e only move forward/backward to discrete input values)
#[derive(Clone, Debug)]
pub enum StepDirection {

Can you make the repr to i8 and set Forward to +1 and Backward to -1? That might make the code above shorter.


Comments from Reviewable

@Rhuagh
Copy link
Member Author

Rhuagh commented Feb 12, 2018

Review status: all files reviewed at latest revision, 1 unresolved discussion.


amethyst_animation/src/resources.rs, line 328 at r1 (raw file):

Previously, torkleyy (Thomas Schaller) wrote…

Can you make the repr to i8 and set Forward to +1 and Backward to -1? That might make the code above shorter.

Not sure, still need to do edge case handling individually so the index don't overflow/underflow.


Comments from Reviewable

@Rhuagh
Copy link
Member Author

Rhuagh commented Feb 12, 2018

Review status: all files reviewed at latest revision, 1 unresolved discussion.


amethyst_animation/src/resources.rs, line 328 at r1 (raw file):

Previously, Rhuagh (Simon Rönnberg) wrote…

Not sure, still need to do edge case handling individually so the index don't overflow/underflow.

It would remove one line, that's about it.


Comments from Reviewable

@Rhuagh
Copy link
Member Author

Rhuagh commented Feb 12, 2018

r? @Xaeroxe @omni-viral

@torkleyy
Copy link
Member

:lgtm:


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

Copy link
Member

@Xaeroxe Xaeroxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bors r+

bors bot added a commit that referenced this pull request Feb 13, 2018
569:  feat: Add stepping and exact input value control to animation system r=Xaeroxe a=Rhuagh

Needs rebase when #567 is merged.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/569)
<!-- Reviewable:end -->
@bors
Copy link
Contributor

bors bot commented Feb 13, 2018

@bors bors bot merged commit 6fc5ca1 into amethyst:develop Feb 13, 2018
@Rhuagh Rhuagh deleted the feature/animation-stepping branch February 13, 2018 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants