Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Encoder::copy_image_to_buffer #252

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Add Encoder::copy_image_to_buffer #252

merged 1 commit into from
Dec 10, 2019

Conversation

fintelia
Copy link
Contributor

@fintelia fintelia commented Dec 2, 2019

The crate currently provides copy_buffer_to_image as well as copy_buffer and copy_image, but the last version is missing.

@fintelia
Copy link
Contributor Author

fintelia commented Dec 8, 2019

The CI failure seems to be unrelated to this patch (something about not having enough disk space to clone the repository on MacOS?)

zakarumych
zakarumych approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@zakarumych zakarumych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

bors r+

bors bot added a commit that referenced this pull request Dec 10, 2019
@bors @fintelia
Merge #252
cae226f 
252: Add Encoder::copy_image_to_buffer r=omni-viral a=fintelia

The crate currently provides `copy_buffer_to_image` as well as `copy_buffer` and `copy_image`, but the last version is missing.

Co-authored-by: Jonathan Behrens <fintelia@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 10, 2019

Build succeeded

@bors bors bot merged commit 1531596 into amethyst:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakarumych zakarumych zakarumych approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fintelia @zakarumych