Fix homogeneous transform computation for prismatic joints #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
approved these changes
Feb 21, 2024
|
We may want also to add some dummy models with prismatic joints to the tests of consistency with iDynTree (that could have its own problems with prismatic models, see robotology/idyntree#1149). |
|
I agree! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @YuchuanLu we discovered this bug preventing computations for prismatic joints.
The sum is not defined for a
listand anarray_like, so I wrapped therpy(that was in a list) in an array.I might come back later for a more smart handling.